Semester picker in administration #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
trochu sa to skroluje ponad - pokusil som sa spravit druhe PR kde som ten semester picker umiestil inde... ale nechcel som ti to pushovat do tohto PR, lebo neviem teraz vecer uz zhodnotit ci to je dobry napad |
|
taktiez v semesterPickery sa nenastavia spravne data, pretoze to nevie z URL precitat ze o ktory semester sa jedna. Je totiz zvyknuty zo stranok zadani a rieseni ze v url je rocnik a nie ID semstra (to znamena ze by nefungovalo keby si nastavila title) - zacinam uvazovat ci je dobry napad pouzit ten isty semster picker (aj ked uprimne si myslim ze to je spravny pristup, lebo ten semesterPicker je dost pouzitelny, len treba zmenit nejake veci v administracii :-D ) |
2 tasks
|
resenie bolo nakoniec mergnute v #323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nie je to velmi pekne spravene, lebo som len upravila semesterPicker, ktory sa pouziva vo vysledkoch a zadaniach, aby sa dal pouzit aj tu. Ale malo by to byt aspon funkcne.