Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts Detail #322

Merged
merged 13 commits into from
Jan 8, 2024
Merged

Posts Detail #322

merged 13 commits into from
Jan 8, 2024

Conversation

Matushl
Copy link
Member

@Matushl Matushl commented Dec 10, 2023

close #261

nastyloval som novy markdown a zakazal som v nom tabulky, mozno som ich tam mohol nechat, ale osobne si myslim ze to tam nepatri

  • je len potrebne dodat do nejakeho issue co ma byt napisane v helpery pre dany markdown field v admine

@Matushl Matushl added the question Nejednoznacne zadanie, treba doladit label Dec 10, 2023
@Matushl Matushl force-pushed the 261-posts-detail branch 2 times, most recently from 6c5b3a4 to 44869a9 Compare December 12, 2023 20:23
@Matushl Matushl removed the question Nejednoznacne zadanie, treba doladit label Dec 13, 2023
@Matushl Matushl requested a review from rtrembecky December 13, 2023 13:55
@Matushl Matushl marked this pull request as ready for review December 13, 2023 13:55
@Matushl Matushl changed the title WIP: Posts' Detail Posts Detail Dec 13, 2023
Copy link
Collaborator

@rtrembecky rtrembecky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dovolil som si prepisat Grid, mohol som to nechat tak, resp. odstranit len redundant usages Gridu, aby to bolo korektne... MUI poskytuje bud Grid component (no v MUI v5 mali nejake problemy, ktore fixuju v unstable tu: https://mui.com/material-ui/react-grid2/), alebo nejake css properties, ktore si spravne pouzil (https://mui.com/system/grid/). ja sa radsej drzim componentov, kym to v nich napisat vieme.

inak asi fajn 🙂

@Matushl
Copy link
Member Author

Matushl commented Jan 8, 2024

@rtrembecky naschal som nepoužil grid2 lebo som čítal že má nejaké chyby a nechcelo sa mi o tom investovať viac. Ale asi cajk aj takto.

@Matushl Matushl merged commit eefe562 into master Jan 8, 2024
1 check passed
@Matushl Matushl deleted the 261-posts-detail branch January 8, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Novinky - Pop-up s dlhym markdown textom prispevku
2 participants