260 ra posts createedit markdown preview #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtrembecky
approved these changes
Apr 13, 2024
| <FormDataConsumer> | ||
| {({formData}) => { | ||
| return ( | ||
| <> |
Comment on lines
15
to
16
| {({formData}) => { | ||
| return ( |
There was a problem hiding this comment.
da sa tiez zbavit curly brackets
Comment on lines
31
to
33
| openDetail={() => { | ||
| openDetail(true) | ||
| }} |
There was a problem hiding this comment.
tiez by som sa zbavil curly.. ale to su nitpick komentare co by som nemal ani pisat 😄
Comment on lines
18
to
21
| <Grid container> | ||
| <Grid xs={6}> | ||
| <Stack gap={5}> | ||
| <Post |
There was a problem hiding this comment.
aasi ok... vravim si, ked pozeram na ten Posts.tsx, ze by sa dalo extrahovat viac, cele UI postov, a v arrayi posts by si tam tuto poslal jeden element. ale asi to teraz nestoji za dalsi effort
| import {theme} from '@/theme' | ||
|
|
||
| export const PostPreview: FC = () => { | ||
| const [isDetailOpen, openDetail] = useState<boolean>() |
There was a problem hiding this comment.
dalsi nit: pisal by som useState(false), aby to nezacinalo na undefined, a typ si to inferuje. doesn't matter really
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.