Conversation
src/components/Problems/Problems.tsx
Outdated
| @@ -56,6 +50,14 @@ export const Problems: FC = () => { | |||
| queryFn: () => axios.get<SeriesWithProblems>(`/api/competition/series/${id.seriesId}`), | |||
| enabled: id.seriesId !== -1, | |||
| }) | |||
|
|
|||
| const {data: bannerMessage, isLoading: isBannerLoading} = useQuery({ | |||
| queryKey: [id.seriesId], | |||
There was a problem hiding this comment.
queryKey by mal matchovat API route segmenty - nemame to nijak automatizovane, no je to globalny kluc react-query, pod ktorym cachuje response, tak cely kluc by mal odrazat, o ake data ide. tu teda asi ['cms', 'info-banner', id.seriesId]
src/components/Problems/Problems.tsx
Outdated
|
|
||
| const {data: bannerMessage, isLoading: isBannerLoading} = useQuery({ | ||
| queryKey: [id.seriesId], | ||
| queryFn: () => axios.get(`/api/cms/info-banner/?series=${id.seriesId}`), |
There was a problem hiding this comment.
axios.get explicitne typujeme, pozri ako je to inde... ked info banner typ nemame generovany z BE (ktory mozno este ani nie je? kedze toto je otvorene ZdruzenieSTROM/webstrom-backend#376), tak pridat manualne do types/api/cms.ts.. ale nejaky InfoBanner type tam vidim
|
|
||
| const {bannerMessages} = BannerContainer.useContainer() | ||
| const divider = ' - ' | ||
| if (bannerMessages === undefined || bannerMessages.length === 0) return <></> |
There was a problem hiding this comment.
absolutny nitpick: ako prazdny element zvyknem vracat null
There was a problem hiding this comment.
Som ho zatial necha zobrazovat kym sa nedohodneme finalne či tam bude alebo nie ... Ak by nebol aj tak treba asi vratit nejaky placeholder aby sa neposúval obsah
No description provided.