-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change font-sizes and adjust common layout to mobile #378
Conversation
src/theme.ts
Outdated
fontSize: pxToRem(32), | ||
[sm]: {fontSize: pxToRem(32)}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xs/sm teda ako su, dokonca vacsie ako md? ci to je, ze uz toho bolo moc a je to na follow-up?
EDIT: aha to su jedine male fonty, ktore si nezmenil. tak mozno si zabudol. kazdopadne, ak vyzeraju dobre, aj tak by som siel na 26 aby to bolo konzistentne s md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no nezabudol, H1 je pouzite len pre nadpis v topbare, kde to vo Figme pre mobil je naozaj take obrovske
akoze mozeme ignorovat ten mobilny design "uplne", nvm co myslis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fontSize: pxToRem(11), | ||
[sm]: {fontSize: pxToRem(11)}, | ||
[md]: {fontSize: pxToRem(9)}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zvlastne vidiet 11/11/9 ale asi ok 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cele tie font size su take divne, tiez ma boleli prsty ked som to pisal
@@ -70,9 +70,9 @@ export const SemesterPicker: FC<{page: 'zadania' | 'vysledky' | 'admin/opravovan | |||
} | |||
|
|||
return ( | |||
<div className={styles.menu}> | |||
<Stack sx={{flexDirection: 'row', alignItems: 'center', gap: 2, zIndex: 1000, userSelect: 'none'}}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idealne Stack direction="row"
a nesahat na flexDirection
priamo.
EDIT: ale doesn't matter, asi sa na to este pozriem potom, ked chcem prerobit SemesterPicker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ja som akosi vsetko natrepal do sx, lebo som mal pocit ze to tak chceme :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
cast riesenia #177, ale bude este potreba dalsie zmeny (mozno rozparsujem na mensie tasky)
komentare ku par commitom: