Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed error message #458

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Changed error message #458

merged 2 commits into from
Nov 23, 2024

Conversation

vgeffer
Copy link
Contributor

@vgeffer vgeffer commented Nov 23, 2024

Not really error, tel. číslo je nepovinný údaj. Ak je zlé, je to chyba používateľa, keďže kratšie čísla musia byť akceptované, najmä kvôli kratším predvoľbám.

closes #436

@vgeffer vgeffer linked an issue Nov 23, 2024 that may be closed by this pull request
@@ -103,7 +103,7 @@ export const RegisterForm: FC = () => {
const phoneRule = {
validate: (val?: string) => {
if (val && !/^(\+\d{10,12})$/u.test(val.replaceAll(/\s+/gu, '')))
return '* Zadaj telefónne číslo vo formáte +421 123 456 789 alebo +421123456789.'
return '* Zadaj telefónne číslo vo formáte +421 123 456 789.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return '* Zadaj telefónne číslo vo formáte +421 123 456 789.'
return '* Zadaj telefónne číslo vo formáte s predvoľbou (napr. +421 123 456 789).'

Copy link
Member

@Matushl Matushl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@vgeffer vgeffer merged commit 199a1c4 into master Nov 23, 2024
1 check passed
@vgeffer vgeffer deleted the 436-phone-number branch November 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pri vyplnení zlého tel. čísla sa neoznačí správne chyba
3 participants