Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full title for problems #459

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Show full title for problems #459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/SemesterPicker/SemesterPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,20 @@ export const SemesterPicker: FC<{page: 'zadania' | 'vysledky' | 'admin/opravovan

useEffect(() => {
// setPageTitle using selectedItem variable
let pageTitleToSet = ''
if (semester) {
const semesterTitle = `${getSemesterYear(semester)} - ${getSemesterName(semester)}`
let pageTitleToSet = semesterTitle
if (page === 'admin/opravovanie') {
pageTitleToSet = `Opravovanie - ${semester.year}/${semester.season_code === 0 ? 'zima' : 'leto'} (${
semester.school_year
})`
} else if (displayWholeSemesterOnResults) {
pageTitleToSet = semesterTitle
} else if (series) {
// ak je page vysledky a zobrazujeme cely semester, tak sa nezobrazuje seria v nazve
// pre seriu sa chceme stale pokusit zobrazit nazov serie
} else if (!(page === 'vysledky' && displayWholeSemesterOnResults) && series) {
pageTitleToSet = `${semesterTitle}${series.order ? ` - ${getSeriesName(series)}` : ''}`
}
setPageTitle(pageTitleToSet)
}
setPageTitle(pageTitleToSet)
// `semester` a `series` su nami vytiahnute objekty, tak mozu triggerovat effekt kazdy render. nemalo by vadit
}, [displayWholeSemesterOnResults, semester, series, page, setPageTitle])

Expand Down
Loading