Adding client C interface for recovery #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omershlo
reviewed
May 29, 2019
| pub extern "C" fn decrypt_party_one_master_key( | ||
| c_master_key_two_json: *const c_char, | ||
| c_helgamal_segmented_json: *const c_char, | ||
| c_private_key: *const c_char |
There was a problem hiding this comment.
it should be specified that this is the escrow private key. otherwise confusing
omershlo
suggested changes
May 29, 2019
There was a problem hiding this comment.
it looks like the flow is (correct me if I missed):
- get escrow private key
- call decrypt party one master key
- go over the entire tree of children and collect x1,x2 from each one (using api calls get_child mk1, get_child mk2)
- for every pair x1,x2 extract the private key.
my questions: why not make one api call for gotham with inputs mk1, mk2 that get output a list of private keys?
even better: one api call with escrow private key and output a list of keys?
The current API structure is very permissive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding client C interface for recovery