-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate semaphore circuit #23
base: main
Are you sure you want to change the base?
feat: integrate semaphore circuit #23
Conversation
@evgongora Kindly review. This is what I came up with. I'll be waiting for your review and suggestions. |
Hey @khayss part of what we need right now is to adjust the circuit to be handled in bls12_381, we understand there might need to be some changes on the companion curve so this won't work for now, mind if we leave research instead with a separate issue? |
Awesme job from your part! |
Sure. A separate issue can be created for the research. I tried spotting as many areas that won't work with stellar but later agreed as well that it should be a separate issue with lot of consideration so I went with this basic one. |
@evgongora Is there anything else you'll like me to add so this PR can be ready for review and possible merge. |
Hey @khayss here is the issue for the doc. Will leave this as a draft |
Should I apply for the docs issue? Also, will this be a draft pending the completion of the docs issue? |
We need to be sure how this is going to be leveraged so let's work on the docs issue for now, go ahead and apply if you want to continue with the issue :) |
Okay. Thank you for the update |
Description
This PR implements a zero-knowledge proof circuit for Semaphore using the BabyJubjub curve.
Changes Made
Related Issues
Closes #16