Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: create sidebar #17

Merged
merged 2 commits into from
Dec 14, 2024
Merged

Conversation

Bran18
Copy link
Contributor

@Bran18 Bran18 commented Dec 13, 2024

Open PR Request - Create Sidebar

Issue: #11

PR Description

Include the sidebar navigation using shadcn sidebar component + other changes to improve the dev exp.

Preview

Screenshot 2024-12-13 at 11 05 47 AM

Build Status

Screenshot 2024-12-13 at 11 10 15 AM

Copy link
Collaborator

@evgongora evgongora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job so far! Just a quick change could you make the sidebar collapsible as shown in the example from shadcn?

Screenshot 2024-12-13 at 11 13 36 AM

@Bran18
Copy link
Contributor Author

Bran18 commented Dec 13, 2024

Great job so far! Just a quick change could you make the sidebar collapsible as shown in the example from shadcn?

Screenshot 2024-12-13 at 11 13 36 AM

Done i just included the SidebarTrigger at the root of your application

@Bran18 Bran18 requested a review from evgongora December 13, 2024 20:05
Copy link
Collaborator

@evgongora evgongora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you so much :)

@evgongora evgongora merged commit 86aa855 into ZencypherSolutions:main Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants