Send additional data to Chobby to be independent from steam overlay #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Licho1
reviewed
Oct 26, 2018
| { | ||
| return GetFriendIDs().Select(x => new SteamFriend() | ||
| { | ||
| Name = SteamFriends.GetFriendPersonaName(x), |
There was a problem hiding this comment.
But avatar would have to be downloaded to an image file in the lobby?! Is it worth doing this for all your steam friends?
|
Added avatar, detailed friend message is described in ZeroK-RTS/Chobby#654 |
DeinFreund
force-pushed
the
freundIDs
branch
from
4871c37 to
2ee5256
Compare
DeinFreund
force-pushed
the
master
branch
12 times, most recently
from
ce1528b to
242f4d7
Compare
DeinFreund
force-pushed
the
master
branch
8 times, most recently
from
f3c5f37 to
5d70725
Compare
|
Just add a dummy function to the lobby interface if you are just being blocked by chobby not handling this. You could even just write a ticket. |
|
@GoogleFrog if we want this, it needs some cooperation on your side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.