Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump cooldown healthbar flashes even on deselected units #5397

Open
sprunk opened this issue Dec 12, 2024 · 1 comment
Open

Jump cooldown healthbar flashes even on deselected units #5397

sprunk opened this issue Dec 12, 2024 · 1 comment

Comments

@sprunk
Copy link
Member

sprunk commented Dec 12, 2024

Amnykon brought it up that perhaps the flashing of jump cooldown healthbar if you have the jump command selected should only happen for selected units.

@GoogleFrog
Copy link
Contributor

Sounds ideal, but I'm not sure what sort of information healthbars has already, and the performance is sort of tight. A solution that only reads unit selection on units with jump bars that could flash (ie at the last conditional) sounds fine. If there is no per-unit flash ability for jump bars (eg if they are drawn in a big batch with one colour) then I am not so sure. I haven't looked at the code in a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants