Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Compact h3-4 #830

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

MAINT: Compact h3-4 #830

wants to merge 40 commits into from

Conversation

Zeroto521
Copy link
Owner

@Zeroto521 Zeroto521 commented Dec 31, 2022

Compat with h3-py 4 veriosn

@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Attention: Patch coverage is 31.57895% with 13 lines in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (2877a5c) to head (59f8c8d).

Files with missing lines Patch % Lines
dtoolkit/geoaccessor/index/h3.py 21.42% 11 Missing ⚠️
dtoolkit/geoaccessor/index/is_h3.py 0.00% 1 Missing ⚠️
dtoolkit/geoaccessor/series/h3.py 75.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2877a5c) and HEAD (59f8c8d). Click for more details.

HEAD has 147 uploads less than BASE
Flag BASE (2877a5c) HEAD (59f8c8d)
151 4
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #830       +/-   ##
===========================================
- Coverage   99.30%   88.39%   -10.92%     
===========================================
  Files         154      154               
  Lines        2295     2300        +5     
  Branches      497      178      -319     
===========================================
- Hits         2279     2033      -246     
- Misses          7      250      +243     
- Partials        9       17        +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TypeError: _API_FUNCTIONS.geo_to_h3() got an unexpected keyword argument 'res'
@Zeroto521 Zeroto521 added this to the 0.0.21 milestone Jan 14, 2023
@Zeroto521
Copy link
Owner Author

Some methods could be added to accessors

  • h3.cell_number
    • v3: h3_get_base_cell
    • v4: get_base_cell_number
  • h3.distance
    • v3: h3_distance
    • v4: grid_distance

@Zeroto521 Zeroto521 changed the title MAINT: Compat h3-4 MAINT: Compact h3-4 May 22, 2023
@Zeroto521 Zeroto521 modified the milestones: 0.0.21, future Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant