Fix lints around serde integration

ZettaScaleLabs · Jun 26, 2024 · 1999942 · 1999942
1 parent 27676e7
commit 1999942
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 20 deletions.
diff --git a/stabby-abi/Cargo.toml b/stabby-abi/Cargo.toml
@@ -45,7 +45,7 @@ stabby-macros.workspace = true
 abi_stable = { workspace = true, optional = true }
 libc = { workspace = true, optional = true }
 rustversion = { workspace = true }
-serde = { workspace = true, optional = true }
+serde = { workspace = true, optional = true, features = ["derive"] }
 sha2-const-stable = { workspace = true }
 
 [dev-dependencies]

diff --git a/stabby-abi/src/alloc/boxed.rs b/stabby-abi/src/alloc/boxed.rs
@@ -439,12 +439,12 @@ mod serde_impl {
     use super::*;
     use crate::alloc::IAlloc;
     use serde::{Deserialize, Serialize};
-    impl<'a, T: Serialize, Alloc: IAlloc> Serialize for BoxedSlice<T, Alloc> {
+    impl<T: Serialize, Alloc: IAlloc> Serialize for BoxedSlice<T, Alloc> {
         fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
         where
             S: serde::Serializer,
         {
-            let slice: &[T] = &*self;
+            let slice: &[T] = self;
             slice.serialize(serializer)
         }
     }
@@ -456,12 +456,12 @@ mod serde_impl {
             crate::alloc::vec::Vec::deserialize(deserializer).map(Into::into)
         }
     }
-    impl<'a, Alloc: IAlloc> Serialize for BoxedStr<Alloc> {
+    impl<Alloc: IAlloc> Serialize for BoxedStr<Alloc> {
         fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
         where
             S: serde::Serializer,
         {
-            let slice: &str = &*self;
+            let slice: &str = self;
             slice.serialize(serializer)
         }
     }

diff --git a/stabby-abi/src/alloc/string.rs b/stabby-abi/src/alloc/string.rs
@@ -366,12 +366,12 @@ mod serde_impl {
     use super::*;
     use crate::alloc::IAlloc;
     use serde::{Deserialize, Serialize};
-    impl<'a, Alloc: IAlloc> Serialize for String<Alloc> {
+    impl<Alloc: IAlloc> Serialize for String<Alloc> {
         fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
         where
             S: serde::Serializer,
         {
-            let slice: &str = &*self;
+            let slice: &str = self;
             slice.serialize(serializer)
         }
     }

diff --git a/stabby-abi/src/alloc/sync.rs b/stabby-abi/src/alloc/sync.rs
@@ -861,12 +861,12 @@ mod serde_impl {
     use super::*;
     use crate::alloc::IAlloc;
     use serde::{Deserialize, Serialize};
-    impl<'a, T: Serialize, Alloc: IAlloc> Serialize for ArcSlice<T, Alloc> {
+    impl<T: Serialize, Alloc: IAlloc> Serialize for ArcSlice<T, Alloc> {
         fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
         where
             S: serde::Serializer,
         {
-            let slice: &[T] = &*self;
+            let slice: &[T] = self;
             slice.serialize(serializer)
         }
     }
@@ -878,12 +878,12 @@ mod serde_impl {
             crate::alloc::vec::Vec::deserialize(deserializer).map(Into::into)
         }
     }
-    impl<'a, Alloc: IAlloc> Serialize for ArcStr<Alloc> {
+    impl<Alloc: IAlloc> Serialize for ArcStr<Alloc> {
         fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
         where
             S: serde::Serializer,
         {
-            let slice: &str = &*self;
+            let slice: &str = self;
             slice.serialize(serializer)
         }
     }

diff --git a/stabby-abi/src/alloc/vec.rs b/stabby-abi/src/alloc/vec.rs
@@ -824,12 +824,12 @@ mod serde_impl {
     use super::*;
     use crate::alloc::IAlloc;
     use serde::{de::Visitor, Deserialize, Serialize};
-    impl<'a, T: Serialize, Alloc: IAlloc> Serialize for Vec<T, Alloc> {
+    impl<T: Serialize, Alloc: IAlloc> Serialize for Vec<T, Alloc> {
         fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
         where
             S: serde::Serializer,
         {
-            let slice: &[T] = &*self;
+            let slice: &[T] = self;
             slice.serialize(serializer)
         }
     }

diff --git a/stabby-abi/src/num.rs b/stabby-abi/src/num.rs
@@ -1,3 +1,4 @@
+
 /// Returned when using [`core::convert::TryInto`] on the illegal value of a restricted integer.
 #[crate::stabby]
 #[derive(Clone, Copy, Default, Debug, Ord, PartialEq, PartialOrd, Eq, Hash)]

diff --git a/stabby-abi/src/result.rs b/stabby-abi/src/result.rs
@@ -563,7 +563,7 @@ mod serde_impl {
         where
             S: serde::Serializer,
         {
-            let this: core::result::Result<_, _> = self.as_ref().into();
+            let this: core::result::Result<_, _> = self.as_ref();
             this.serialize(serializer)
         }
     }

diff --git a/stabby-abi/src/slice.rs b/stabby-abi/src/slice.rs
@@ -205,7 +205,7 @@ mod serde_impl {
         where
             S: serde::Serializer,
         {
-            let slice: &[T] = &*self;
+            let slice: &[T] = self;
             slice.serialize(serializer)
         }
     }
@@ -214,7 +214,7 @@ mod serde_impl {
         where
             S: serde::Serializer,
         {
-            let slice: &[T] = &*self;
+            let slice: &[T] = self;
             slice.serialize(serializer)
         }
     }

diff --git a/stabby-abi/src/str.rs b/stabby-abi/src/str.rs
@@ -53,7 +53,7 @@ impl<'a> From<Str<'a>> for &'a str {
 }
 impl AsRef<str> for Str<'_> {
     fn as_ref(&self) -> &str {
-        &*self
+        self
     }
 }
 impl<'a> Deref for Str<'a> {
@@ -85,7 +85,7 @@ pub struct StrMut<'a> {
 }
 impl AsRef<str> for StrMut<'_> {
     fn as_ref(&self) -> &str {
-        &*self
+        self
     }
 }
 impl<'a> Deref for StrMut<'a> {
@@ -134,15 +134,15 @@ mod serde_impl {
         where
             S: serde::Serializer,
         {
-            serializer.serialize_str(&*self)
+            serializer.serialize_str(self)
         }
     }
     impl<'a> Serialize for StrMut<'a> {
         fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
         where
             S: serde::Serializer,
         {
-            serializer.serialize_str(&*self)
+            serializer.serialize_str(self)
         }
     }
     impl<'a> Deserialize<'a> for Str<'a> {