Dyn struct creation added to Dyn struct documentation #61
Conversation
…eate Dyn struct from: - borrows of trait implementors - heap allocated owned trait implementors - thread safe owned trait implementors
|
This is lovely, thank you :) I prefer to keep discussions in English to maximize accessibility, but thanks for offering :) I have some quick fixing to do now that 1.77 is out to make the CI happy again, in the meantime, would you mind either signing the ECA or simply adding a comment to this PR acknowledging that you are agreeing to your changes being licenced under Eclipse + Apache 2 licensing? :) |
|
FYI, I'm looking to relocate your example to somewhere that's both more visible and easier to make compile, since it also acts as a test, but doesn't compile as is due to imports :) |
|
Ah yeah the breaking change for nightly still plagues the build assuming that get's fixed then the changes I made could be added. Likely under a different pull request. I only changed the document comments not the body of structs, functions, etc. If you point me in the direction of what is wrong then I might be able to fix it. This pull request could be merged now and change nothing in regards to functionality though. It only adds documentation. |
|
I've just published Working on a proper tutorial for |
|
For reference, here's the branch on which I'm working on the tutorial: #63 This way of doing things will integrate the tutorial as the documentation for an empty |
|
Thank you. I will check it out and try to make sense of it. I will let you
know if I have any questions. Hopefully I will not have questions and will
just be able to apply changes to help you
…On Thursday, March 28, 2024, Pierre Avital ***@***.***> wrote:
For reference, here's the branch on which I'm working on the tutorial: #63
<#63>
This way of doing things will integrate the tutorial as the documentation
for an empty tutorial module, ensuring that all examples compile (or
voluntarily fail to compile) and run as expected.
—
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK62PSUBIQMYRJ3SCU6CVA3Y2QIDTAVCNFSM6AAAAABFIKFGXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVGI2TSNBSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I see you have a pending pull request. I'll wait to see if that gets merged
or not and then send my ideas in a pull request
…On Fri, Mar 29, 2024 at 2:23 PM Zach Schlitt ***@***.***> wrote:
Thank you. I will check it out and try to make sense of it. I will let you
know if I have any questions. Hopefully I will not have questions and will
just be able to apply changes to help you
On Thursday, March 28, 2024, Pierre Avital ***@***.***>
wrote:
> For reference, here's the branch on which I'm working on the tutorial:
> #63 <#63>
>
> This way of doing things will integrate the tutorial as the documentation
> for an empty tutorial module, ensuring that all examples compile (or
> voluntarily fail to compile) and run as expected.
>
> —
> Reply to this email directly, view it on GitHub
> <#61 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AK62PSUBIQMYRJ3SCU6CVA3Y2QIDTAVCNFSM6AAAAABFIKFGXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRVGI2TSNBSG4>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
I demonstrate how to create Dyn structs through the dynptr macro and the from method of the Dyn struct's From trait implementation. My examples demonstrate much of what is described in the Traits section of the Readme. It may not otherwise be apparent to some how to create Dyn structs and DynRef structs. Even for those that do find out how to having these examples makes learning how to occur quicker. This in turn should make your library even more appealing. If the documentation is against your guidelines in any way let me know how it is against your guidelines and I can fix it. I have other ideas for improved documentaton but thought before I write those I should make sure I can submit documentation changes in without clashing with your guidelines. Merci beaucoup pour votre logiciel! Préférez-vous les discussions de demande de tirage en anglais ou français?