Interop gas charging workaround #1723
Open
+380
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ere-the-calling-contract-was-deployed-before-a-configured-block
bzawisto
changed the title
…ere-the-calling-contract-was-deployed-before-a-configured-block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a workaround and performs different gas tracking for evm->scilla calls. In order to figure out if such logic should be applied, each account has additional creation_at_block field saying if it's ZQ1 or ZQ2(block_number).
Since we need to know how much gas is left inside the precompile - each evm run has thin ZQ2Inspector which tracks gas left and stores the value in PendingSubstate. Later, PendingSubstate is accessible from precompile and we can provide suitable value to scilla runs from precompile.