Remove MDNS #1830
Closed
Remove MDNS #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(feat) Be more conservative in deleting blocks from the block_store (fix) Remember to remove requests from the in-flight requests queue when we get a response (feat) admin_ mechanisms to draw graphs of node arrangements and interrupt comms (feat) z2 commands to partition the network and dump out node arrangements (feat) A configuration file for zq2-richard (feat) z2 deployer info and command-line options to specify hosts for z2 deployer install and upgrade (feat) Scripts to allow you to easily(ish) run dhat and oprofile on zilliqa processes (feat) A ZQ2_API_URL env var for deposit txns so you can insert mitmweb to work out why they are failing. (feat) List API URLs in z deployer info
|
Duplicate of JH's recent PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(this PR applies on top of #1829 )
GCP only partly supports mdns and local networks don't support it at all; having it present encourages libp2p to think it can locate peers using mdns and do work that it doesn't need to do. It also leads to an odd situation with local networks (where nodes have no globally visible address) where all packets have to be passed using illegitimate mdns broadcasts because we refuse to accept any of the addresses identify identifies (they are all classed as non-global and our code discards them).
This patch removes mdns, simplifying our libp2p config. zq2-richard is at block 106,000 and some with it, so I hope it's not too deleterious ..