Implement GetBlockchainInfo #1895
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously had placeholders in it All the fields of the return are also available as other API endpoints. For transaction rate, tx block rate, and sharding_structure I delegated to the other APIs, but for the others I didn't, for a two main reasons: 1. To avoid repeatedly locking and unlocking the `Arc<Mutex<Node>>`, which felt like it'd be slow 2. Some of the APIs convert numbers to strings to return them, and I thought re-parsing them would be inelegant. I could have converted them all the wrappers but that seemed a bit too much. This already has a test which I added in #1864
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the fields of the return are also available as other API endpoints. For transaction rate, tx block rate, and sharding_structure I delegated to the other APIs, but for the others I didn't, for a two main reasons:
Arc<Mutex<Node>>, which felt like it'd be slowThis already has a test which I added in #1864