Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cell, basecell, and enough code to implement Valid() #1

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

iandees
Copy link
Collaborator

@iandees iandees commented Dec 23, 2024

No description provided.

@iandees iandees requested a review from Copilot December 23, 2024 16:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

pkg/h3/cell_test.go:42

  • Add more test cases to cover edge cases and invalid inputs.
}

pkg/h3/cell.go:140

  • Ensure that the type conversion to baseCell is handled correctly and does not introduce any unexpected behavior.
return baseCell((uint64(c) & H3_BC_MASK) >> H3_BC_OFFSET)
@iandees iandees merged commit 9e58460 into main Dec 23, 2024
1 check passed
@iandees iandees deleted the cell-isvalid branch December 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant