Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor InitGlobalLogger to Accept String Level Argument #14

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

lucaslopezf
Copy link
Contributor

@lucaslopezf lucaslopezf commented Sep 13, 2023

This Pull Request refactors the InitGlobalLogger function to accept a log level as a string. The change makes it easier to configure the logger by simply passing in a string that represents the desired log level.

@lucaslopezf lucaslopezf marked this pull request as ready for review September 13, 2023 20:44
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

pkg/cli/logging.go Outdated Show resolved Hide resolved
pkg/cli/logging.go Outdated Show resolved Hide resolved
@lucaslopezf lucaslopezf merged commit 7ba291b into main Sep 14, 2023
1 check passed
@lucaslopezf lucaslopezf deleted the feat/log-level branch September 14, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants