Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POSIX implementation of ExpandPath #9

Closed
wants to merge 8 commits into from

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Aug 26, 2023

The function ExpandPath does not implement the tilde expansion as mandated by POSIX, i.e. a tilde-prefix could be followed by a valid login name; in that case, the tilde-prefix shall be replaced by the home directory associated with that login name.

See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html for more information.

🔗 zboto Link

The function ExpandPath does not implement the tilde
expansion as mandated by POSIX, i.e. a tilde-prefix
could be followed by a valid login name; in that case,
the tilde-prefix shall be replaced by the home directory
associated with that login name.

See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html
for more information.
@jleni
Copy link
Member

jleni commented Aug 30, 2023

Mamma mia! Alessio 🎸 rockstar! nice to you see around man!
This is a part of an internal project, are you planning to use it somehow?

Copy link
Contributor

@bizk bizk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, would improve the testing with assertions

@alessio
Copy link
Contributor Author

alessio commented Sep 16, 2023

Looks good to me, would improve the testing with assertions

Done, thanks!

@alessio
Copy link
Contributor Author

alessio commented Sep 23, 2023

@jleni gentle bump :)

@alessio alessio requested a review from bizk September 25, 2023 13:39
@alessio
Copy link
Contributor Author

alessio commented Oct 18, 2023

bump :)

@alessio alessio requested a review from jleni December 5, 2023 21:55
@alessio
Copy link
Contributor Author

alessio commented Dec 6, 2023

I fixed the tests. It should be good to go now.

@alessio
Copy link
Contributor Author

alessio commented Dec 14, 2023

Superseded by #36

@alessio alessio closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants