-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POSIX implementation of ExpandPath #9
Conversation
The function ExpandPath does not implement the tilde expansion as mandated by POSIX, i.e. a tilde-prefix could be followed by a valid login name; in that case, the tilde-prefix shall be replaced by the home directory associated with that login name. See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html for more information.
Mamma mia! Alessio 🎸 rockstar! nice to you see around man! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, would improve the testing with assertions
Done, thanks! |
@jleni gentle bump :) |
bump :) |
I fixed the tests. It should be good to go now. |
Superseded by #36 |
The function ExpandPath does not implement the tilde expansion as mandated by POSIX, i.e. a tilde-prefix could be followed by a valid login name; in that case, the tilde-prefix shall be replaced by the home directory associated with that login name.
See https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html for more information.
🔗 zboto Link