-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add ton jettons #26
base: feat/ton
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty solid so far @ayelenmurano!!! It looks great!!
11f60a9
to
102dbc5
Compare
@@ -18595,8 +18595,10 @@ var package_default = { | |||
"coin:bitcoin": "pnpm --filter coin-bitcoin", | |||
"coin:evm": "pnpm --filter coin-evm", | |||
"coin:framework": "pnpm --filter coin-framework", | |||
"coin:tester": "pnpm --filter coin-tester", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be unrelated change...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I'll delete it. Thanks for realizing it!
libs/env/src/env.ts
Outdated
@@ -775,8 +775,9 @@ const envDefinitions = { | |||
parser: intParser, | |||
desc: "Configure the low battery percentage threshold", | |||
}, | |||
// TODO: TON switch to mainnet | |||
API_TON_ENDPOINT: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could move this to config.ts
like in near https://github.com/LedgerHQ/ledger-live/blob/e7ed028716bccb9dc29aa2fc672ecc7a3e78276a/libs/coin-modules/coin-near/src/config.ts
I think they recently added this way of adding env config variables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good idea! I hadn't seen it. I'll add the endpoint and key from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks pretty great to me!! π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to me too π
b4a06ec
to
7a1ed78
Compare
af132dc
to
3c3a8c5
Compare
Upgrade pnpm to version 9.4.0
This reverts commit 1843b41.
feat(lld): refactor of breadcrumb for nft gallery
* fix: LIVE-13279 * feat: stop caching results from fallback + throws correctly when network error * chore: changeset * chore: var renaming * chore: const in caps
β¦Q#7229) chore: add scenario that fails on the trustchain app
* fix: coin-tester polkadot runtime upgrade * fix: update changelog * fix: update polkadot nano app firmware version in coin-tester * fix: lint error
* fix: revert ignoring all swaps error * chore: changeset
[QAA][Playwright] Fix playwright mocked test for features flags prod
β¦os_firebase_testing [QAA-137][Speculos] Change back firebase env to testing
Upgrade Turborepo to 2.0.6
Revert Turborepo 2
01d342f
to
5fc15d5
Compare
96a344b
to
3445486
Compare
β Checklist
npx changeset
was attached.π Description
Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.
β Context
π§ Checklist for the PR Reviewers