Empty memo issue #93
Merged
Empty memo issue #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
chcmedeiros
commented
Dec 4, 2024
chcmedeiros
commented
- update zxlib and zemu
- add condition to not print memo when it's empty
- add testcase for this type of tx
neithanmo
approved these changes
Dec 4, 2024
| @@ -38,6 +38,18 @@ parser_error_t _read(parser_context_t *ctx, parser_tx_t *v) { | |||
| return parser_ok; | |||
| } | |||
|
|
|||
| bool hasMemoToPrint(const parser_context_t *ctx) { | |||
| // Check if memoSection exists and has a commitmentDiscriminant | |||
| if ((ctx->tx_obj->transaction.header.memoSection != NULL && | |||
There was a problem hiding this comment.
Maybe no need for the if? and just return the (comparisons),however this way is a bit more explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.