Spend auth signature #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
approved these changes
Dec 23, 2024
src/app.ts
Outdated
| return { | ||
| signature: signatureResponse.readBytes(signatureResponse.length()), | ||
| spendAuth_signature: spendAuthSignature |
There was a problem hiding this comment.
I think we are using camel case generally. Don't you think it is better to stick to that?
neithanmo
approved these changes
Dec 23, 2024
src/app.ts
Outdated
| @@ -46,6 +44,8 @@ export class PenumbraApp extends BaseApp { | |||
| SIGN: 0x02, | |||
| FVK: 0x03, | |||
| TX_METADATA: 0x04, | |||
| GET_SPEND_AUTH_SIGNATURES: 0x05, | |||
| GET_BINDING_SIGNATURES: 0x06, | |||
There was a problem hiding this comment.
GET_DELEGATOR_SIGNATURES??
neithanmo
added a commit
that referenced
this pull request
Dec 23, 2024
* Feat/metadata (#4) * Add tx metadata instruction and handle it correctly * Remove address index from sign method * not send metadata if it is empty --------- Co-authored-by: abenso <[email protected]> * Spend auth signature (#5) * add spend auth and delegator vote signatures --------- Co-authored-by: Natanael Mojica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an API to retrieve the spend authorization signature