Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output and memo ui #14

Open
wants to merge 27 commits into
base: feat/ui
Choose a base branch
from
Open

Output and memo ui #14

wants to merge 27 commits into from

Conversation

abenso
Copy link
Collaborator

@abenso abenso commented Dec 9, 2024

  • Output plan UI
  • Memo UI
  • Fix parameters UI
  • Fix print value
  • Fix print address

app/src/parser.c Outdated
Comment on lines 85 to 91
switch (ctx->tx_obj->actions_plan[i].action_type) {
case penumbra_core_transaction_v1_ActionPlan_output_tag:
CHECK_ERROR(output_getNumItems(ctx, &action_num_items));
break;
default:
return parser_unexpected_error;
}

Check notice

Code scanning / CodeQL

No trivial switch statements

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/parser.c Outdated
Comment on lines 149 to 156
switch (ctx->tx_obj->actions_plan[action_idx].action_type) {
case penumbra_core_transaction_v1_ActionPlan_output_tag:
CHECK_ERROR(output_getItem(ctx, &ctx->tx_obj->actions_plan[action_idx].action.output, 0, outKey, outKeyLen,
outVal, outValLen, pageIdx, pageCount))
break;
default:
return parser_unexpected_error;
}

Check notice

Code scanning / CodeQL

No trivial switch statements

This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/plan/output_plan.c Fixed Show fixed Hide fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants