-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output and memo ui #14
Open
abenso
wants to merge
27
commits into
feat/ui
Choose a base branch
from
feat/memo_ui
base: feat/ui
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
abenso
commented
Dec 9, 2024
- Output plan UI
- Memo UI
- Fix parameters UI
- Fix print value
- Fix print address
app/src/parser.c
Outdated
Comment on lines
85
to
91
switch (ctx->tx_obj->actions_plan[i].action_type) { | ||
case penumbra_core_transaction_v1_ActionPlan_output_tag: | ||
CHECK_ERROR(output_getNumItems(ctx, &action_num_items)); | ||
break; | ||
default: | ||
return parser_unexpected_error; | ||
} |
Check notice
Code scanning / CodeQL
No trivial switch statements
This switch statement should either handle more cases, or be rewritten as an if statement.
app/src/parser.c
Outdated
Comment on lines
149
to
156
switch (ctx->tx_obj->actions_plan[action_idx].action_type) { | ||
case penumbra_core_transaction_v1_ActionPlan_output_tag: | ||
CHECK_ERROR(output_getItem(ctx, &ctx->tx_obj->actions_plan[action_idx].action.output, 0, outKey, outKeyLen, | ||
outVal, outValLen, pageIdx, pageCount)) | ||
break; | ||
default: | ||
return parser_unexpected_error; | ||
} |
Check notice
Code scanning / CodeQL
No trivial switch statements
This switch statement should either handle more cases, or be rewritten as an if statement.
neithanmo
force-pushed
the
feat/memo_ui
branch
from
December 10, 2024 13:14
b9fd3ce
to
f3eba8f
Compare
would reduce final binary size
neithanmo
force-pushed
the
feat/memo_ui
branch
from
December 10, 2024 13:26
f3eba8f
to
88a16d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.