Disable all penumbre api for nanos #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
neithanmo
commented
Nov 22, 2024
neithanmo
commented
- fix nanos compilation issue by removing all penumbra functionality which causes large binary sizes not compatible for that target
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/apdu_handler.c
Outdated
Comment on lines
309
to
313
| switch (G_io_apdu_buffer[OFFSET_INS]) { | ||
| case INS_GET_VERSION: { | ||
| handle_getversion(flags, tx); | ||
| break; | ||
| } | ||
| #if defined(APP_TESTING) | ||
| case INS_TEST: { | ||
| handleTest(flags, tx, rx); | ||
| THROW(APDU_CODE_OK); | ||
| break; | ||
| } | ||
| #endif | ||
| default: | ||
| zemu_log("ins_not_supported**\n"); | ||
| THROW(APDU_CODE_INS_NOT_SUPPORTED); | ||
| } |
Check notice
Code scanning / CodeQL
No trivial switch statements
neithanmo
force-pushed
the
fix/nanos_compilation
branch
from
35c9f8e to
c33b9e2
Compare
abenso
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.