Swap and Ics 20 Withdrawal effect hash #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abenso
force-pushed
the
feat/swap-ics-20-hash
branch
from
de7c1eb to
53b6b39
Compare
neithanmo
approved these changes
Nov 29, 2024
|
|
||
| pub fn to_proto_swap(&self) -> [u8; Self::PROTO_LEN] { | ||
| let mut proto = [0u8; Self::PROTO_LEN]; | ||
| proto[0..4].copy_from_slice(&[0x22, 0x22, 0x0a, 0x20]); |
There was a problem hiding this comment.
From where that array values come from?
There was a problem hiding this comment.
These bytes are for protobuf headers. If the .proto file is modified, these bytes may change. We can discuss if there is another way to make this more flexible
|
|
||
| pub fn to_proto_swap(&self) -> [u8; Self::PROTO_LEN] { | ||
| let mut proto = [0u8; Self::PROTO_LEN]; | ||
| proto[0..4].copy_from_slice(&[0x0a, 0x22, 0x0a, 0x20]); |
There was a problem hiding this comment.
You can also define that array as a constant, similarly to Self::PROTO_LEN
app/rust/src/parser/trading_pair.rs
Outdated
|
|
||
| pub fn to_bytes(&self) -> Result<[u8; 64], ParserError> { | ||
| let mut bytes = [0u8; 64]; | ||
| let asset_1_bytes = self.asset_1.to_bytes().expect("asset_1 conversion failed"); |
There was a problem hiding this comment.
Let's not use expect or unwraps, however if the code execution path would never fail, unwrap is preferable because it does not have the overhead of a static string in the final binary, also a safety comment explaining a bit why it won't panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser and computation of effect hash of Swap and Ics 20 Withdrawal actions