Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COSE Signed API #165

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

COSE Signed API #165

wants to merge 9 commits into from

Conversation

nodh
Copy link
Contributor

@nodh nodh commented Nov 13, 2024 •
edited
Loading

Uses type parameter from CoseSigned to clarify usages of the payload (and reduce the number of manual tagging payloads).

See also a-sit-plus/signum#194

@nodh nodh self-assigned this Nov 13, 2024
@nodh nodh mentioned this pull request Nov 13, 2024
Open
JesusMcCloud
JesusMcCloud approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@JesusMcCloud JesusMcCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reflects the changes, so I'm approving even if the Signum-PR is not yet through

@nodh
WIP: Adapt to changes in signum for COSE types
b0ee6f6 
Still throws this error:

Captured type parameter P of at.asitplus.wallet.lib.cbor.DefaultCoseService.asCosePayload? from generic non-reified function. Such functionality cannot be supported because P is erased, either specify serializer explicitly or make calling function inline with reified P.
@nodh nodh requested a review from n0900 November 20, 2024 11:24
@n0900
Copy link
Contributor

n0900 commented Nov 20, 2024 •
edited
Loading

I could not find a very convenient way to serialize the classes.
Using this branch in combination with a-sit-plus/signum#194 if you make the generic nullable and extend the case-distinction all tests seem to work except for Tag24SerializationTest where the structure of the encoded issued credential differs by a tag D818 and all else being equal.

Attached are the two outputs
newEncoded.txt
previousEncoded.txt
The difference is the tag in line 27.

Please let me know if we want to pursue this further

@n0900 n0900 self-assigned this Nov 21, 2024
@n0900 n0900 removed their request for review November 21, 2024 09:07
JesusMcCloud
JesusMcCloud approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@JesusMcCloud JesusMcCloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work! As far as I can see, this covers all our cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusMcCloud JesusMcCloud JesusMcCloud approved these changes

Assignees

@nodh nodh

@n0900 n0900

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nodh @n0900 @JesusMcCloud