Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast u64 montgomery conversion #185

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

moodlezoup
Copy link
Collaborator

@moodlezoup moodlezoup commented Feb 26, 2024

Uses our fork of arkworks/algebra to leverage fast conversion from u64s to field elements (in Montgomery form)
Companion PR: a16z/arkworks-algebra#2

@moodlezoup moodlezoup requested a review from sragss February 26, 2024 19:14
Copy link
Collaborator

@sragss sragss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jolt-core/Cargo.toml Outdated Show resolved Hide resolved
jolt-core/src/jolt/subtable/sra_sign.rs Outdated Show resolved Hide resolved
@moodlezoup moodlezoup force-pushed the optimize/fast-montgomery-conversion branch from b6bbf51 to 38f9d7a Compare February 28, 2024 16:55
@moodlezoup moodlezoup merged commit 1151696 into jolt Feb 28, 2024
@moodlezoup moodlezoup deleted the optimize/fast-montgomery-conversion branch March 27, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants