fix: add memory_layout to preprocessing so verifier doesn't rely on the prover #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagar-a16z
force-pushed
the
sagar/refactor_memory_layout
branch
from
124f0df to
ac2a9af
Compare
sagar-a16z
changed the title
moodlezoup
reviewed
Oct 31, 2024
| self.build(); | ||
| let elf = self.elf.unwrap(); | ||
| let elf = self.elf.clone().unwrap(); |
There was a problem hiding this comment.
we shouldn't need this clone, we pass in elf by reference below
There was a problem hiding this comment.
Self.elf is an Option<PathBuf> the clone is required to unwrap it. Previously this API would consume itself trace(mut self), which seemed weird to me so I changed it to trace(&mut self) and that means we can't just pull elf out of Self anymore since we just have a ref to Self.
Does that make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory layout is a public input to the Jolt verifier and doesn't need to be trusted from the Proof
fixes #490