fix(jolt-core): Fixes & lookup saving for ValidRemainder instrs
#507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
AssertValidSignedRemainderwhen either of the operands is the minimumi32/i64number. This is becauselookup_entry()invokes.abs()which panics when this minimum value is passed in. The fix is to use the panic-freeunsigned_abs()version instead.AssertValidUnsignedRemainder. This savings is similar to the one inSLTU, since the less-than unsigned function computation does not require the result of looking up the last chunk toEqSubtable.