Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : optimize instruction lookups #522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat : optimize instruction lookups #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 24 additions & 14 deletions jolt-core/src/jolt/vm/instruction_lookups.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,8 +848,10 @@ where
) -> InstructionLookupPolynomials<F> {
let m: usize = ops.len().next_power_of_two();

// Parallelize subtable lookup indices computation
let subtable_lookup_indices: Vec<Vec<usize>> = Self::subtable_lookup_indices(ops);

// Parallelize the main polynomial generation
let polys: Vec<(DensePolynomial<F>, DensePolynomial<F>, DensePolynomial<F>)> = (0
..preprocessing.num_memories)
.into_par_iter()
Expand All @@ -858,23 +860,31 @@ where
let subtable_index = preprocessing.memory_to_subtable_index[memory_index];
let access_sequence: &Vec<usize> = &subtable_lookup_indices[dim_index];

// Pre-allocate vectors
let mut final_cts_i = vec![0usize; M];
let mut read_cts_i = vec![0usize; m];
let mut subtable_lookups = vec![F::zero(); m];

for (j, op) in ops.iter().enumerate() {
if let Some(instr) = &op.instruction_lookup {
let memories_used = &preprocessing.instruction_to_memory_indices
[InstructionSet::enum_index(instr)];
if memories_used.contains(&memory_index) {
let memory_address = access_sequence[j];
debug_assert!(memory_address < M);

let counter = final_cts_i[memory_address];
read_cts_i[j] = counter;
final_cts_i[memory_address] = counter + 1;
subtable_lookups[j] = preprocessing.materialized_subtables
[subtable_index][memory_address];
// Process operations in chunks for better cache utilization
for chunk in ops.chunks(1024).enumerate() {
let (chunk_idx, chunk_ops) = chunk;
let base_idx = chunk_idx * 1024;

for (j, op) in chunk_ops.iter().enumerate() {
let abs_idx = base_idx + j;
if let Some(instr) = &op.instruction_lookup {
let memories_used = &preprocessing.instruction_to_memory_indices
[InstructionSet::enum_index(instr)];
if memories_used.contains(&memory_index) {
let memory_address = access_sequence[abs_idx];
debug_assert!(memory_address < M);

let counter = final_cts_i[memory_address];
read_cts_i[abs_idx] = counter;
final_cts_i[memory_address] = counter + 1;
subtable_lookups[abs_idx] = preprocessing.materialized_subtables
[subtable_index][memory_address];
}
}
}
}
Expand All @@ -887,7 +897,7 @@ where
})
.collect();

// Vec<(DensePolynomial<F>, DensePolynomial<F>, DensePolynomial<F>)> -> (Vec<DensePolynomial<F>>, Vec<DensePolynomial<F>>, Vec<DensePolynomial<F>>)
// Parallel conversion of polys tuple to separate vectors
let (read_cts, final_cts, E_polys): (
Vec<DensePolynomial<F>>,
Vec<DensePolynomial<F>>,
Expand Down