Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimization crushing the second Spartan sumcheck. Instead of the inner sumcheck with
a * b
rounds wherea = num_vars_padded
andb = num_steps_padded
, we now perform two sumchecks ofa
rounds andb
rounds, respectively.There's a lot to document. I'm making the PR for now to unblock @moodlezoup's other optimizations.
A major change in the code that we should discuss before merging:
builder.rs
).How ready is the PR? It's good enough to build on but needs cleanup before merging into main.
key.rs
).Also need to test with flamegraphs to make sure we're seeing the right performance improvements in the prover's sumchecks.