Fix file DOWNLOAD strangeness #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If EXPECTED_HASH is passed to file(DOWNLOAD), it seems to be sending error message and skips few stack frames and returns. This causes package management not to retry failure next time! With this change, hash check is explicitly implemented.
a9183756-gh
force-pushed
the
fix/file_dl_hash_chk
branch
from
3e6c31d to
cade004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If EXPECTED_HASH is passed to file(DOWNLOAD), it seems to be
sending error message and skips few stack frames and returns.
This causes package management not to retry failure next time!
With this change, hash check is explicitly implemented.