Skip to content
This repository has been archived by the owner on Sep 7, 2024. It is now read-only.

did not delete in original areas #1

Closed
wants to merge 17 commits into from
Closed

did not delete in original areas #1

wants to merge 17 commits into from

Conversation

outzhu
Copy link

@outzhu outzhu commented Oct 11, 2021

only copied,
did not delete

@oxr463
Copy link
Contributor

oxr463 commented Oct 11, 2021

Assuming this is related to aad-for-linux/aad-for-linux#19

@outzhu
Copy link
Author

outzhu commented Oct 11, 2021

yes

@oxr463 oxr463 self-requested a review October 11, 2021 18:27
libnss-aad/docker/amazon/2018.03/Dockerfile Outdated Show resolved Hide resolved
libnss-aad/docker/amazon/Dockerfile Outdated Show resolved Hide resolved
libnss-aad/docker/debian/Dockerfile Outdated Show resolved Hide resolved
libnss-aad/docker/debian/Dockerfile Outdated Show resolved Hide resolved
libnss-aad/docker/ubuntu/Dockerfile Outdated Show resolved Hide resolved
pam_aad/docker/amazon/2018.03/Dockerfile Outdated Show resolved Hide resolved
pam_aad/docker/amazon/Dockerfile Outdated Show resolved Hide resolved
pam_aad/docker/debian/Dockerfile Outdated Show resolved Hide resolved
pam_aad/docker/debian/Dockerfile Outdated Show resolved Hide resolved
pam_aad/docker/ubuntu/Dockerfile Outdated Show resolved Hide resolved
@oxr463 oxr463 added the hacktoberfest-accepted Hacktoberfest 2021 label Oct 11, 2021
Copy link
Author

@outzhu outzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should do it.

pam_aad/debian/Dockerfile Outdated Show resolved Hide resolved
@outzhu
Copy link
Author

outzhu commented Oct 12, 2021

Made changes. Please review.

pam_aad/rocky/Dockerfile Outdated Show resolved Hide resolved
@oxr463
Copy link
Contributor

oxr463 commented Oct 27, 2021

@Ada-Codina what's the status on this?

@outzhu
Copy link
Author

outzhu commented Oct 27, 2021

Checked for the packages specific versions that were available in rocky/alpine, rename the ones that were there and removed the ones that weren't.

I left the lines empty so you can check what's been rename/removed.

@oxr463
Copy link
Contributor

oxr463 commented Oct 27, 2021

Checked for the packages specific versions that were available in rocky/alpine, rename the ones that were there and removed the ones that weren't.

I left the lines empty so you can check what's been rename/removed.

Can you remove the empty lines and make a list of missing packages as a comment?

Copy link
Contributor

@oxr463 oxr463 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things:

  • Please rename the libnss-aad directory to libnss_aad.
  • Once all the changes have been made, we need to test by building each docker image (Let me know if you need help).

libnss-aad/alpine/Dockerfile Outdated Show resolved Hide resolved
libnss-aad/alpine/Dockerfile Outdated Show resolved Hide resolved
libnss-aad/alpine/Dockerfile Outdated Show resolved Hide resolved
libnss-aad/alpine/Dockerfile Outdated Show resolved Hide resolved
libnss-aad/rocky/Dockerfile Outdated Show resolved Hide resolved
pam_aad/alpine/Dockerfile Outdated Show resolved Hide resolved
pam_aad/rocky/Dockerfile Outdated Show resolved Hide resolved
pam_aad/rocky/Dockerfile Outdated Show resolved Hide resolved
Comment on lines +25 to +31
ENV SDSMIRROR="https://gitlab.com/oxr463/sds/-/jobs/210491217/artifacts/raw" \
SDSVERSION="2.0.0" SDSDEBVERSION="2.0.0-1"
WORKDIR /tmp
RUN curl -LO "${SDSMIRROR}/libsds${SDSVERSION}_${SDSDEBVERSION}_amd64.deb" && \
curl -LO "${SDSMIRROR}/libsds-dev_${SDSDEBVERSION}_amd64.deb" && \
dpkg -i "libsds${SDSVERSION}_${SDSDEBVERSION}_amd64.deb" && \
dpkg -i "libsds-dev_${SDSDEBVERSION}_amd64.deb"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to port SDS since we can't use the Debian package.

pam_aad/rocky/Dockerfile Outdated Show resolved Hide resolved
@outzhu
Copy link
Author

outzhu commented Oct 27, 2021

libnss_aad's missing packeges

Alpine's Dockerfile
autopoint
build-essential
debhelper
devscripts
libcurl4-openssl-dev
libjwt-dev
libssl-dev
libxcrypt-dev
pkg-config

Rocky's Dockerfile
autopoint
build-essential
debhelper
devscripts
libjwt-dev
libsodium-dev
libssl-dev
pkg-config

pam_aad's missing packages

Alpine's Dockerfile
build-essential
debhelper
devscripts
libcurl4-openssl-dev
libjwt-dev
libssl-dev
libtool
pkg-config
uuid-dev

Rocky's Dockerfile
build-essential
debhelper
devscripts
libcurl4-openssl-dev
libjwt-dev
libpam0g-dev
libssl-dev
pkg-config
uuid-dev

@oxr463
Copy link
Contributor

oxr463 commented Nov 2, 2021

[ ] Once all the changes have been made, we need to test by building each docker image (Let me know if you need help).

See: #2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest-accepted Hacktoberfest 2021
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants