Add a regression test for #656 #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #656
I came here to fix that linked issue, but it turns out that the issue no longer reproduces on the latest version.
Digging around, I can confirm that commit e1986a4 was the one that fixed it. I can't quite tell why that would be, but this exact automated test definitely passes at that version and definitely fails immediately before. 🤷
Regardless, before I call it "good enough", I would appreciate it if you could add this automated test to the repository as a safeguard, especially since I can't tell why that commit "ought" to have fixed this.