Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add trimming support #917

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Conversation

zivillian
Copy link

@zivillian zivillian commented Mar 25, 2024

I started to prepare the library for trmming according to documentation.

My goal was to be able to publish my project (which uses YamlDotNet) trimmed without getting a warning. I know, that there was some previous work in #740 and #758, but even though I used a static context it still produced warnings because YamlDotNet is not marked as trimmable.

Now I'm a bit stuck, because the docs recommend to

Avoid annotating virtual methods or interface methods.

But there are still ~60 warnings, but all remaining methods are either overrides or interface implementations.

Since I've spent a few hours, I didn't want to just throw it away and instead created this draft. Maybe someone has an idea how to continue.


I've deleted some methods and files, because they were unused, internal and produced additional trim warnings - so deleting was easier than annotating them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant