Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #106 CDC Serial send blocks when host closes connection #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NicoHood
Copy link
Contributor

I've only added it for the sending part, as Receiving should work independent. Maybe you know better if we also need it there, but I dont think so as it wont block anything.

@NicoHood
Copy link
Contributor Author

NicoHood commented Apr 2, 2018

@abcminiuser Any chance to see this feature in the near feature?

@abcminiuser
Copy link
Owner

Looks ok to me, but some people might want a class driver config option to ignore DTR. I'm about to leave on a business trip to the US for 10 days, I'll have to go through this and the other patches when I get back.

@NicoHood
Copy link
Contributor Author

NicoHood commented Apr 4, 2018

You could add it as compile time option to keep compatibility to older APIs. But i would enable it as default, that makes sense to me.

@abcminiuser
Copy link
Owner

I think the best course of action is to add a new RequireDTR option to the Config section of USB_ClassInfo_CDC_Device_t, and set that to true in all the demos in the LUFA tree. That way people with old code will get the old behavior for backwards compatibility, but those basing their code off the latest LUFA version will have it enabled by default.

@NicoHood
Copy link
Contributor Author

But it will increase the code size even more, on top of the DTR check itself. It should be either the new default or a compile time option if you ask me. This is nothing you would want to change at runtime.

@tmk tmk mentioned this pull request Nov 21, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants