Skip to content

Commit

Permalink
Merge pull request #48 from ably/release/2.0.0
Browse files Browse the repository at this point in the history
Release/2.0.0
  • Loading branch information
QuintinWillison authored Sep 27, 2022
2 parents 30dd8a1 + 8408e39 commit 4662408
Show file tree
Hide file tree
Showing 8 changed files with 166 additions and 127 deletions.
19 changes: 17 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,22 @@
# Changelog

## Version 2 (yet to be released)
## [2.0.0](https://github.com/ably/sdk-upload-action/tree/v2.0.0)

[Full Changelog](https://github.com/ably/sdk-upload-action/compare/v1.3.0...v2.0.0)

This release includes the following breaking changes:

- Removes support for S3 Access Key to be used to directly specify the IAM user.
GitHub OIDC is now required.
- Makes the `artifactName` Action input optional, allowing artifacts to be uploaded to the root of the deployment context.
- Enforces that the `githubToken` and `sourcePath` inputs are supplied when the Action is run.

And the following new feature:

- The `artifactName` Action input is now optional, allowing artifacts to be uploaded to the root of the deployment context.

**Merged pull requests:**

- Enforce that required inputs are supplied [\#47](https://github.com/ably/sdk-upload-action/pull/47) ([QuintinWillison](https://github.com/QuintinWillison))
- Make `artifactName` input optional [\#46](https://github.com/ably/sdk-upload-action/pull/46) ([QuintinWillison](https://github.com/QuintinWillison))
- Remove deprecated S3 access method [\#44](https://github.com/ably/sdk-upload-action/pull/44) ([QuintinWillison](https://github.com/QuintinWillison))
- Move+Sync Node.js versions to Active LTS and add check workflow [\#43](https://github.com/ably/sdk-upload-action/pull/43) ([QuintinWillison](https://github.com/QuintinWillison))
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
8. Push a tag with the absolute new version number to GitHub, which must be in the form `v<major>.<minor>.<patch>` - e.g. `v1.3.0`
9. Move the tag for the `major` version number to the same commit, which will be in the form `v<major>` - e.g. `v1`

Commits made in steps 1 thru 5 should ideally be pushed to a release branch, seeking approval from others to land to `main` (default) branch prior to adding and moving tags.
Commits made in steps 1 thru 7 should ideally be pushed to a release branch, seeking approval from others to land to `main` (default) branch prior to adding and moving tags.

## See Also

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ steps:
aws-region: eu-west-2
role-to-assume: arn:aws:iam::${{ secrets.ABLY_AWS_ACCOUNT_ID_SDK }}:role/ably-sdk-builds-<REPO-NAME>
role-session-name: "${{ github.run_id }}-${{ github.run_number }}"
- uses: ably/sdk-upload-action@v1
- uses: ably/sdk-upload-action@v2
with:
sourcePath: doc/api
githubToken: ${{ secrets.GITHUB_TOKEN }}
Expand Down
Loading

0 comments on commit 4662408

Please sign in to comment.