Skip to content

Commit

Permalink
Remove unnecessary call to trim() on string returned by the getInput(…
Browse files Browse the repository at this point in the history
…) core API.
  • Loading branch information
QuintinWillison committed Sep 26, 2022
1 parent b7f091b commit 59e5d89
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ const ref = createRef(githubRef)

const s3BucketName = 'sdk.ably.com';
const sourcePath = path.resolve(core.getInput('sourcePath'));
const artifactName = core.getInput('artifactName').trim(); // empty string indicates no value, i.e. artifact name not specified

// Optional artifactName:
// - The getInput() method calls trim() for us by default (trimWhitespace: true)
// - Empty string indicates no value, i.e. artifact name not specified
const artifactName = core.getInput('artifactName');

let githubDeploymentRef: string;
let s3KeyPrefix = `builds/${context.repo.owner}/${context.repo.repo}/`;
Expand Down

0 comments on commit 59e5d89

Please sign in to comment.