Importers bugfix [nginx, debian_oval, ubuntu] #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A minor bug was introduced by 775aa1d which was crashing the nginx importer. Signed-off-by: Hritik Vijay <[email protected]>
Recent time travel heuristics need published date of versions, thus Version dataclass was created. Some of the importers got bugged by this new system and were crashing. This fix is a part of # 467 Importers bugged: - nginx - debian_oval - ubuntu Signed-off-by: Hritik Vijay <[email protected]>
Hritik14
force-pushed
the
importer-bugfix
branch
from
26e91f7
to
71a3d75
Compare
sbs2001
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update importers to handle VersionResponse
Recent time travel heuristics need published date of versions, thus
Version dataclass was created. Some of the importers got bugged by this
new system and were crashing. This fix is a part of #467
Importers bugged:
Signed-off-by: Hritik Vijay [email protected]
NOTE: 26e91f7 should be reconsidered if #500 plans to revert #467
Fix recursion in GitHubTagsAPI
A minor bug was introduced by 775aa1d which was crashing the nginx
importer.
Signed-off-by: Hritik Vijay [email protected]