NOISSUE - Add Redis Cache For SpiceDB #2239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
9 times, most recently
from
74e7614
to
2d7a24d
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
5 times, most recently
from
8cc4456
to
faff4a4
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
6 times, most recently
from
2832853
to
9458c32
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
from
9458c32
to
45b66c1
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
3 times, most recently
from
d2a96d0
to
c188992
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
5 times, most recently
from
ebde9c4
to
5e146fa
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
2 times, most recently
from
469409d
to
dae32fb
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
3 times, most recently
from
c0cb67d
to
c9f8213
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
from
c9f8213
to
a243a79
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
from
a243a79
to
3aa29c9
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
from
3aa29c9
to
22d3bea
Compare
dborovcanin
force-pushed
the
noissue-cache-policies
branch
from
22d3bea
to
3c9951b
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
from
3c9951b
to
c4022bc
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
2 times, most recently
from
c9cb220
to
bc79284
Compare
dborovcanin
force-pushed
the
noissue-cache-policies
branch
from
bc79284
to
fb7b67c
Compare
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
from
81b121e
to
d486cb4
Compare
Cache policies when the first authorization request happens and delete them when removing policies Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
noissue-cache-policies
branch
from
d486cb4
to
8fca4a2
Compare
|
Let's put this on hold until a new Auth is in place. We will do some Auth caching regardless of SpiceDB, so this PR will probably be closed. |
|
We will be doing caching differently, and it will be resolved by https://github.com/absmach/magistrala/pull/2494. Closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature PR because it adds policy caching to Redis to make auth calls faster
What does this do?
Cache policies when the first authorization request happens and delete them when removing policies
Which issue(s) does this PR fix/relate to?
No issue
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
Yes, I have updated the documentation for the new feature.
Notes