MG-2404 - Use Policy CRUD wrapper to directly talk to SpiceDB #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
mg2404-policy
branch
2 times, most recently
from
a55448b
to
b7083b8
Compare
felixgateru
changed the title
felixgateru
force-pushed
the
mg2404-policy
branch
from
b7083b8
to
3835e97
Compare
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
felixgateru
force-pushed
the
mg2404-policy
branch
from
3835e97
to
c2172fc
Compare
dborovcanin
changed the title
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
requested changes
Sep 5, 2024
pkg/policy/policy.go
Outdated
| // authorization services (e.g. ORY Keto). | ||
| // | ||
| //go:generate mockery --name PolicyAgent --output=./mocks --filename agent.go --quiet --note "Copyright (c) Abstract Machines" | ||
| type PolicyAgent interface { |
There was a problem hiding this comment.
Do we need the both Agent and Client, especially since they have almost exactly the same interface?
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
requested changes
Sep 5, 2024
| @@ -30,18 +30,18 @@ type service struct { | |||
| clients postgres.Repository | |||
| idProvider magistrala.IDProvider | |||
| auth grpcclient.AuthServiceClient | |||
| policy policy.PolicyService | |||
| policy policy.PolicyClient | |||
There was a problem hiding this comment.
Rename to policyClient.
| "github.com/absmach/magistrala/users/postgres" | ||
| ) | ||
|
|
||
| const defLimit = uint64(100) | ||
|
|
||
| type handler struct { | ||
| clients postgres.Repository | ||
| policy policy.PolicyService | ||
| policy magistrala.PolicyServiceClient |
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
approved these changes
Sep 6, 2024
dborovcanin
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Sep 12, 2024
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Sep 13, 2024
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Sep 24, 2024
Signed-off-by: 1998-felix <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Sep 25, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: nyagamunene <[email protected]>
dborovcanin
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Sep 27, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: nyagamunene <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Sep 30, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Sep 30, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Oct 1, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: nyagamunene <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Oct 3, 2024
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Oct 7, 2024
Signed-off-by: 1998-felix <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Oct 7, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: nyagamunene <[email protected]>
dborovcanin
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Oct 8, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: nyagamunene <[email protected]>
nyagamunene
pushed a commit
to nyagamunene/supermq
that referenced
this pull request
Oct 8, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: nyagamunene <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Oct 8, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Oct 8, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: Felix Gateru <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Oct 14, 2024
Signed-off-by: 1998-felix <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Oct 15, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]>
felixgateru
added a commit
that referenced
this pull request
Oct 15, 2024
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Oct 15, 2024
Signed-off-by: 1998-felix <[email protected]>
dborovcanin
pushed a commit
to dborovcanin/supermq
that referenced
this pull request
Oct 15, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: Dusan Borovcanin <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Oct 15, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: Felix Gateru <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Oct 15, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: Felix Gateru <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Oct 17, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: Felix Gateru <[email protected]>
dborovcanin
pushed a commit
that referenced
this pull request
Oct 17, 2024
Signed-off-by: 1998-felix <[email protected]> Signed-off-by: Dusan Borovcanin <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Oct 24, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: Dusan Borovcanin <[email protected]>
felixgateru
added a commit
to felixgateru/magistrala
that referenced
this pull request
Oct 24, 2024
…h#2405) Signed-off-by: 1998-felix <[email protected]> Signed-off-by: Felix Gateru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it replaces policy gRPC client in policy CRUD wrapper with direct communication with SpiceDB.
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No, tests for the policy wrapper will be included in subsequent prs.
Did you document any new/modified feature?
Yes, in code documentation for functions has been updated.
Notes