-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: comment with rspec-stderr #2330
base: main
Are you sure you want to change the base?
Conversation
We should avoid introducing noisy warnings in our test output.
Rspec stderr output:warning: parser/current is loading parser/ruby33, which recognizes 3.3.5-compliant syntax, but you are running 3.3.4. |
This comment was marked as resolved.
This comment was marked as resolved.
It looks like it is using |
Optimally, not only from the rspec step. Also, it would be nice to fix that warning before merging this. |
Maybe I should make the step fail after posting, so that Dependabot PRs are not auto merged. |
This removes a deprecation warning about ruby and parser gem mismatch. Not going to 3.3.5 because it prints a deprecation warning with the current version of `pry` (fixed in `master`, waiting for a release). Clean the deprecation warning for #2330
For readability
Oops. All the steps are being run twice (push and pull_request), wasting resources. |
I will test it on another project first. Turning it into a draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really interesting idea.
I do wonder if people will learn to ignore this message that same way as normal terminal output.
I wish there was a way to print only the additional error output added by the PR's branch
We should avoid introducing noisy warnings in our test output.
Often the warnings are added by Dependabot upgrades. This way we will notice when it happens.
Make sure that your repository has no output when you merge/cherry-pick this, to avoid adding noise to every PR.