Add absorber tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| namespace { | ||
|
|
||
| // S1..4 types can be one of the following: | ||
| // |String|, |ConstString|, |Literal| or |const char*| |
There was a problem hiding this comment.
const char*is highly discouraged and shouldn't be mentioned and used.ConstStringis known asImmutableright now.
dreamer-dead
force-pushed
the
add-adsorber-tests
branch
from
623abe9 to
919c1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to solve #29 , I decided to add some new Absorber tests.
Also added some helper functions.
Please, take a look.