Update syntax of join

aces · Dec 13, 2024 · 13a5ddb · 13a5ddb
1 parent e801021
commit 13a5ddb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/php/libraries/Utility.class.inc b/php/libraries/Utility.class.inc
@@ -716,7 +716,7 @@ class Utility
         } elseif (!is_null($commentID)) { //get sourcefield using commentid
             $instrument   = $DB->pselectOne(
                 "SELECT Test_name FROM flag
-                 JOIN test_names ON test_names.ID = flag.TestID
+                 JOIN test_names ON (test_names.ID = flag.TestID)
                  WHERE CommentID = :cid",
                 ['cid' => $commentID]
             );

diff --git a/tools/data_integrity/data_deletion/delete_timepoint.php b/tools/data_integrity/data_deletion/delete_timepoint.php
@@ -182,7 +182,7 @@ function deleteTimepoint(
     $instruments = $DB->pselect(
         'SELECT Test_name, CommentID
          FROM flag
-         JOIN test_names ON test_names.ID = flag.TestID
+         JOIN test_names ON (test_names.ID = flag.TestID)
          WHERE SessionID=:sid',
         ['sid' => $sessionID]
     );

diff --git a/tools/data_integrity_check.php b/tools/data_integrity_check.php
@@ -40,7 +40,7 @@
         LEFT JOIN
             test_names
         ON
-            test_names.ID = flag.TestID
+            (test_names.ID = flag.TestID)
         WHERE
             Test_name = :instrument AND
             {$instrument}.CommentID IS NULL
@@ -87,7 +87,7 @@
     JOIN
         test_names
     ON
-        test_names.ID = flag.TestID
+        (test_names.ID = flag.TestID)
     WHERE
         (
             flag.CommentID NOT LIKE 'DDE_%' AND
@@ -99,7 +99,7 @@
                 JOIN
                     test_names
                 ON
-                    test_names.ID = flag.TestID
+                    (test_names.ID = flag.TestID)
                 WHERE
                     test.CommentID NOT LIKE 'DDE_%' AND
                     flag.SessionID = test.SessionID AND
@@ -116,7 +116,7 @@
                 JOIN
                     test_names
                 ON
-                    test_names.ID = flag.TestID
+                    (test_names.ID = flag.TestID)
                 WHERE
                     test.CommentID LIKE 'DDE_%' AND
                     flag.SessionID = test.SessionID AND

diff --git a/tools/fix_timepoint_date_problems.php b/tools/fix_timepoint_date_problems.php
@@ -428,7 +428,7 @@ function addInstrument($sessionID, $testName, $loris)
 
     // get CommentID of the newly assigned instrument
     $query = "SELECT CommentID FROM flag
-              JOIN test_names ON test_names.ID = flag.TestID
+              JOIN test_names ON (test_names.ID = flag.TestID)
               WHERE SessionID='$sessionID'
               AND Test_name='$testName'";