[document_repository] Error for filenames with comma (#9461)

Fix downloading of files with commas in document repository by url encoding the filename.
aces · Nov 18, 2024 · 4f15b00 · 4f15b00
1 parent 464dd8b
commit 4f15b00
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/modules/document_repository/jsx/docIndex.js b/modules/document_repository/jsx/docIndex.js
@@ -183,7 +183,7 @@ class DocIndex extends React.Component {
         <a
           href={downloadURL}
           target="_blank"
-          download={row['File Name']}
+          download={encodeURIComponent(row['File Name'])}
         >
           {cell}
         </a>

diff --git a/php/libraries/FilesDownloadHandler.php b/php/libraries/FilesDownloadHandler.php
@@ -99,7 +99,7 @@ public function handle(ServerRequestInterface $request) : ResponseInterface
         return (new \LORIS\Http\Response\JSON\OK())
             ->withHeader(
                 'Content-Disposition',
-                'attachment; filename=' . $filename
+                'attachment; filename=' . urlencode($filename)
             )
             ->withHeader(
                 'Content-Type',