[dataquery] New Data Query Module #8907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a Module->getQueryEngine() function to the Module class to get the QueryEngine to the module. The default is a NullQueryEngine which does nothing and matches nothing. Update the dictionary module to use the new interface instead of Module->getDataDictionary().
driusan
added
Release: Add to release notes
|
@zaliqarosli sorry, I forgot to send this PR after the demo! |
Closed
|
@zaliqarosli I requested your review because I had to choose someone to test how it affects the GitHub Roadmap project. Please disregard for now (unless you want to review.) |
driusan
force-pushed
the
NewestDQTFrontendRebased2
branch
4 times, most recently
from
27dfef6 to
9cafb7e
Compare
This defines the schema I've been using to design a QueryEngine (rather than CouchDB) based data query tool.
This describes what is POSTed and also goes directly into a subfield of a Query object, not directly into the query.
This was causing bugs when tested on RB
|
@CamilleBeau @zaliqarosli I believe I've addressed both of your reviews |
There is a bug in DataTable which needs to be fixed, but this should work once it is
CamilleBeau
requested changes
Dec 5, 2023
|
This has been through a few review/testing/fixing cycles. Merging so that we can move on to the next phase (imaging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a completely new, couchdb free data query module based on the LORIS data query framework and the API introduced in PR#8268.
This (Draft) PR merges all the dependent PRs but will be continually re-based and taken out of draft mode once it is narrowed down to only the new module's javascript. You can review this PR, but if it's not part of the module's typescript please put the comment on the appropriate blocking PR instead.
In the new module, all queries that are run by the user are saved into a history. The user can star or name a query in order to make it easier to find, rather than having to decide ahead of time that they want to save or share a query. Admins can pin queries (either to the top of the module or to the LORIS dashboard).
The UI is also (generally) simplified and more context-sensitive. The "define filters" tab should be easier to understand. The view data tab has a new view where candidates are rows, fields are columns, and session-scoped variables are displayed inline in the cell in a table.
Permissions are enforced for modules, candidates, and sessions.
Blocked by #8880Blocked by #8878Blocked by #8876Blocked by #8873Blocked by #8855Blocked by #8288Blocked by #8940Blocked by #8942Blocked by #8943Blocked by #8944Blocked by #8945Blocked by #8950Blocked by #8958Blocked by #8959Blocked by #8960Testing instructions: No configuration should be required other than running the module's SQL patch.