[media] Fix SQL injection #8908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
Category: Security
This fixes 2 problems with the SQL in the media FileUpload?action=getData endpoint 1. There is an obvious SQL injection attack where user input from the request is directly concatenated into a string that's passed to the database. 2. There was an unnecessary sub-select that could have been a join This whole section of the code is a mess that should to be re-written, but this PR just tackles the urgent string concatenation.
driusan
force-pushed
the
MediaSQLInjection
branch
from
a7ac54b to
0bf6cd0
Compare
CamilleBeau
approved these changes
Oct 3, 2023
CamilleBeau
added
the
Passed manual tests
|
Tested and reviewed, working well and looks good. |
|
@driusan , can we get this merge today? I would like to have it on HBCD and tomorrow would be ideal because it's maintenance day. |
|
@xlecours @CamilleBeau reviewed and approved it so yes. Do you need the release tagged today or just the PR merged? |
|
@driusan it can wait tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 problems with the SQL in the media FileUpload?action=getData endpoint
This whole section of the code is a mess that should to be re-written, but this PR just tackles the urgent string concatenation.