Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML schema] Fix candidate key to meta #8917

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

zaliqarosli
Copy link
Contributor

Brief summary of changes

When querying a specific candidate with api/v0.0.4-dev/candidates/$id/ endpoint, the returned object looks like this:

{"Meta":{"CandID":"000001","Project":"COPN","PSCID":"CA0003","Site":"University of Calgary","EDC":null,"DoB":"1956-01-01","Sex":"Male"},"Visits":{"InitialVisit":"99999","SampleCollection01":"99991"}}

The inline_response_200_2 object should have the 'Meta' property instead of 'Candidate' as key to the Candidate object

Testing instructions (if applicable)

Link(s) to related issue(s)

  • Resolves # (Reference the issue this fixes, if any.)

@zaliqarosli
Copy link
Contributor Author

@driusan let me know if this should go to a release branch instead for a bugfix

@driusan
Copy link
Collaborator

driusan commented Oct 16, 2023

@zaliqarosli If I'm understanding the schema.yml correctly this looks like a bug fix that brings it inline with the markdown documentation, so I think this should go to a release branch, but I'm not 100% sure if my parsing of the YML is correct so I'd like @xlecours to confirm/review before merging.

@zaliqarosli
Copy link
Contributor Author

@driusan yes exactly, the correct key in the code is also 'Meta'

@driusan driusan merged commit ccbc13a into aces:main Oct 24, 2023
19 checks passed
@ridz1208 ridz1208 added this to the 26.0.0 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants